Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(driver/pgsql): optimize regex for version matching #3583

Merged
merged 4 commits into from
May 21, 2024

Conversation

yincongcyincong
Copy link
Contributor

Please ensure you adhere to every item in this list.
every time function Index and version execute, these regexp are initialized. which situation reduce the performance.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
cmd/gf/internal/cmd/cmd_build.go Outdated Show resolved Hide resolved
contrib/drivers/pgsql/pgsql_tables.go Outdated Show resolved Hide resolved
@gqcn gqcn changed the title cmd: optimise regex driver/pgsql: optimize regex for version matching May 16, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@gqcn gqcn merged commit 15b6046 into gogf:master May 21, 2024
23 checks passed
@yincongcyincong yincongcyincong deleted the optimise_regex branch May 27, 2024 12:53
@gqcn gqcn changed the title driver/pgsql: optimize regex for version matching perf(driver/pgsql): optimize regex for version matching Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants