Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix testifylint errors in middleware #2805

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

nickajacks1
Copy link
Member

Description

Update various assertions in the middleware packages to match testify best practices in preparation for an upcoming update to golangci-lint. For float comparisons, an epsilon of 0.1% was chosen somewhat arbitrarily.

https://github.com/Antonboom/testifylint

Type of Change

  • Code consistency (non-breaking change which improves code reliability and robustness)

Checklist

  • Conducted a self-review of the code and provided comments for complex or critical parts.
  • Added or updated unit tests to validate the effectiveness of the changes or new features.
  • Ensured that new and existing unit tests pass locally with the changes.
  • Verified that any new dependencies are essential and have been agreed upon by the maintainers/community.

Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@ReneWerner87 ReneWerner87 merged commit 827013d into gofiber:main Jan 21, 2024
12 checks passed
@efectn
Copy link
Member

efectn commented Jan 21, 2024

We should enable testifylint on golangci-lint golangci/golangci-lint#4103

@gaby
Copy link
Member

gaby commented Jan 21, 2024

We should enable testifylint on golangci-lint golangci/golangci-lint#4103

It requires updating golanci-lint first. But yes, makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants