encodeMap() error handling and TestEncoder_UnmarshallableTypes() #674
+80
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I encountered an issue where unmarshallable types in maps do not properly handle errors.
bytes, err := yaml.Marshal(map[string]any{"a": make(chan int)})
returns a nil error andstring(bytes)
is<nil>\n
.Similarly, calling Marshal on nested
map[string]any{"a": map[string]any{"b": make(chan string)}}
returns a nil error andstring(bytes)
is%!v(PANIC=String method: runtime error: invalid memory address or nil pointer dereference)\n
Solution
Add error to return value in
func (e *Encoder) encodeMap(ctx context.Context, value reflect.Value, column int) (ast.Node, error)
and return the error when value can't be encoded.Testing
Add new
func TestEncoder_UnmarshallableTypes(t *testing.T)
with these test cases: