Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panicking if a bad regexp is returned after converting glob pattern to regexp #983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid panicking if a bad regexp is returned after converting glob pattern to regexp #983

wants to merge 1 commit into from

Conversation

rdelcampog
Copy link

Fixes #982

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check

codespearhead
codespearhead suggested changes Apr 5, 2024
View reviewed changes
Copy link

@codespearhead codespearhead left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you implement that change in all other instances of regexp.MustCompile in the codebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codespearhead codespearhead codespearhead requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid panicking if a bad regexp is returned when hijacking using an incorrect pattern
2 participants
@rdelcampog @codespearhead