Add PagePool.MustGet, modify Get method allow error return rather recover panic. #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeoxisca
changed the title
zeoxisca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PagePool
The
PagePool.Getcan now only acceptcreate func() *Pageas input, so there is no way to output the error that may exist in the create func other than using a closure, and it is inconvenient for users in a multi-routine environment to perform logical processing based on the actual error that occurred.However, I'm not sure whether this change would be in line with the original design.
By the way,
PagePool.CleanUpmay stuck whileppis not full. I also think this might be an issue when using PagePool.