Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes Error in FieldError's interface #666

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Includes Error in FieldError's interface #666

merged 1 commit into from
Sep 27, 2020

Conversation

DavidLarsKetch
Copy link
Contributor

@DavidLarsKetch DavidLarsKetch commented Sep 16, 2020

Fixes Or Enhances #420

There seemed to be an intention to include Error in the FieldError interface since fieldError has that method. This simplified passing along error messages for errors that I didn't want to write my own custom message for.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Change Details:

  • Includes Error method in FieldError, a method already implemented on the unexported fieldError struct

@go-playground/admins

Sorry, something went wrong.

@DavidLarsKetch DavidLarsKetch changed the title Includes Error in FieldError's interface Includes Error in FieldError's interface; fixes #420 Sep 16, 2020
@DavidLarsKetch DavidLarsKetch changed the title Includes Error in FieldError's interface; fixes #420 Includes Error in FieldError's interface Sep 16, 2020
@deankarn deankarn merged commit 4cd2e40 into go-playground:master Sep 27, 2020
@DavidLarsKetch DavidLarsKetch deleted the patch branch September 28, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants