use mail.ParseAddress to cover missing email validations #1395
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb2011
changed the title
nodivbyzero
reviewed
Mar 11, 2025
| errs = validate.Var(s, "email") | ||
| NotEqual(t, errs, nil) | ||
| AssertError(t, errs, "", "", "", "", "email") | ||
|
|
There was a problem hiding this comment.
Let's include one more test case.
s = "Foo Bar <foobar@example.com>"
errs = validate.Var(s, "email")
NotEqual(t, errs, nil)
There was a problem hiding this comment.
Done, added this test as well
|
This seems more robust, no problem with merging this |
|
Thanks mates, waiting for the merge, I want to clean the temp hack (override of the default email validate) from my code (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers