Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server/handshake_resp_test.go 's mysql doc link can't be opened #782

Merged
merged 4 commits into from
Apr 8, 2023

Conversation

zhiiw
Copy link
Contributor

@zhiiw zhiiw commented Apr 8, 2023

the mysql doc link in server/handshake_resp_test.go is out of date .

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lance6716 lance6716 merged commit e928039 into go-mysql-org:master Apr 8, 2023
@zhiiw zhiiw deleted the doc-fix branch April 8, 2023 04:19
@zhiiw
Copy link
Contributor Author

zhiiw commented Apr 8, 2023

By the way ,the server/handshake_resp.go 's test function TestReadPluginName says it use the example data in mysql doc ,but the newest doc don't have the three example data.... So how to deal with this situation ?

@lance6716
Copy link
Collaborator

By the way ,the server/handshake_resp.go 's test function TestReadPluginName says it use the example data in mysql doc ,but the newest doc don't have the three example data.... So how to deal with this situation ?

https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_handshake_response.html#sect_protocol_connection_phase_packets_protocol_handshake_response41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants