Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug that values of time(1),time(3),time(5) will generate 00:00:00 #529

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Conversation

dev-GGBond
Copy link

select case语法错误,造成time字段精度time(1),time(3),time(5)值为00:00:00

@lance6716
Copy link
Collaborator

Hi, could you add a test case for this PR?

@lance6716
Copy link
Collaborator

I tested this PR manualy

MySQL [test]> create table t (c time(5));
Query OK, 0 rows affected (0.086 sec)

MySQL [test]> insert into t values('12:34:56.12345');
Query OK, 1 row affected (0.009 sec)
=== WriteRowsEventV2 ===
Date: 2021-06-22 11:29:41
Log position: 3376
Event size: 42
TableID: 12993
Flags: 1
Column count: 1
Values:
--
0:"12:34:56.123450"

before this PR, it's 00:00:00

Will change the PR description to English and merge it later.

cc @atercattus

@lance6716 lance6716 changed the title select case语法错误,造成time字段精度time(1),time(3),time(5)值为00:00:00 fix a bug that values of time(1),time(3),time(5) will generate 00:00:00 Jun 22, 2021
@lance6716 lance6716 merged commit 13d123b into go-mysql-org:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants