New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain relationship between Logger{} and Discard() #182

Merged

thockin merged 1 commit into go-logr:master from pohly:zero-logger-comment

Apr 24, 2023

Contributor

pohly commented Apr 24, 2023

The zero logger used to crash, but that was fixed recently.


          docs: explain relationship between Logger{} and Discard()

d1c8001

The zero logger used to crash, but that was fixed recently.

github-actions bot assigned pohly and thockin

pohly mentioned this pull request

PR #166 introduced a breaking change in a patch release #180

Closed

thockin reviewed

View reviewed changes

Contributor

thockin left a comment

Thanks!

/lgtm
/approve

thockin merged commit 6134c6a into go-logr:master

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment