Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funcr: optimize WithValues/WithName/WithCallDepth #165

Merged
merged 1 commit into from
Dec 3, 2022
Merged

funcr: optimize WithValues/WithName/WithCallDepth #165

merged 1 commit into from
Dec 3, 2022

Commits on Dec 3, 2022

  1. funcr: optimize WithValues/WithName/WithCallDepth 

    All of these functions indirectly copied the entire Options struct because it
gets stored by value in the Formatter and thus fnlogger. The struct is
read-only, therefore sharing a single copy by pointer via different logger
instances is possible. Performance for the context value benchmark got better.
    @pohly
    pohly committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b58e16f View commit details
    Browse the repository at this point in the history