Avoid using max() and underscores in numbers

go-jose · Mar 7, 2024 · 15e60b7 · 15e60b7
1 parent 158656a
commit 15e60b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/encoding.go b/encoding.go
@@ -106,7 +106,10 @@ func inflate(input []byte) ([]byte, error) {
 	output := new(bytes.Buffer)
 	reader := flate.NewReader(bytes.NewBuffer(input))
 
-	maxCompressedSize := max(250_000, 10*int64(len(input)))
+	maxCompressedSize := 10 * int64(len(input))
+	if maxCompressedSize < 250000 {
+		maxCompressedSize = 250000
+	}
 
 	limit := maxCompressedSize + 1
 	n, err := io.CopyN(output, reader, limit)

diff --git a/encoding_test.go b/encoding_test.go
@@ -63,7 +63,7 @@ func TestInvalidCompression(t *testing.T) {
 // compression ratio is reasonable.
 func TestLargeZip(t *testing.T) {
 	input := new(bytes.Buffer)
-	_, err := io.CopyN(input, rand.Reader, 251_000)
+	_, err := io.CopyN(input, rand.Reader, 251000)
 	if err != nil {
 		t.Fatalf("generating input: %s", err)
 	}
@@ -79,7 +79,7 @@ func TestLargeZip(t *testing.T) {
 }
 
 func TestZipBomb(t *testing.T) {
-	input := strings.Repeat("a", 251_000)
+	input := strings.Repeat("a", 251000)
 	compressed, err := compress(DEFLATE, []byte(input))
 	if err != nil {
 		t.Errorf("compressing: %s", err)