Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sql render bug after use ReplaceDB & UseDB lost db context #1014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clcy1243
Copy link

@clcy1243 clcy1243 commented Nov 2, 2023

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

fix bugs

  1. DO.UseDB will lost db.Statement.Context
  2. DO.ReplaceDB will lost table name
  3. DO.ReplaceDB will not clone db.Statement, so after Query.ReplaceDB, all Dao use same Statement

User Case Description

before fixed, u.Not(gen.Exists(student.Where(u.ID.EqCol(student.ID)))).Count() will return error after call q.ReplaceDB()

@clcy1243
Copy link
Author

clcy1243 commented Nov 3, 2023

@qqxhb please check this PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant