fix: errors.Join defined for go1.19 or below will not work using unsafe.String #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peczenyj
force-pushed
the
fix-errors-join-2
branch
from
5237bc6
to
663c9bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 86.01% 86.13% +0.11%
==========================================
Files 8 9 +1
Lines 236 238 +2
==========================================
+ Hits 203 205 +2
Misses 29 29
Partials 4 4 ☔ View full report in Codecov by Sentry. |
peczenyj
force-pushed
the
fix-errors-join-2
branch
from
663c9bb
to
40c4e14
Compare
|
BTW, since the go.mod specify go 1.20 perhaps we can remove the build tags, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: errors.Join defined for go1.19 or below will not work using unsafe.String, since it is not available on previous go versions
fix #28