Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filer: add io/fs.FS Filer #21

Merged
merged 1 commit into from
Dec 26, 2021
Merged

filer: add io/fs.FS Filer #21

merged 1 commit into from
Dec 26, 2021

Conversation

abursavich
Copy link
Contributor

This adds a Filer implementation for the io/fs stdpkg introduced in go 1.16. It uses this implementation to replace the one used by FromDirectory. It also updates the version of go used in workflows to at least go 1.16.

@bzz
Copy link
Member

bzz commented Dec 26, 2021

Thank you @abursavich for the patch, it looks great to me. Will merge as soon as CI is 🟢

@bzz
Copy link
Member

bzz commented Dec 26, 2021

Windows tests seem to be failing for a while now 😞
Apparently that is at least partially due to us not handling platform-dependent newline char 🤦

That does not seem to be related to the change though, so 👍

@bzz bzz mentioned this pull request Dec 26, 2021
@bzz bzz merged commit a3c55f6 into go-enry:master Dec 26, 2021
@MrDOS MrDOS mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants