checkers/rules/rules.go:dynamicFmtString: advice doc string Fixes #1381 #1438
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix the doc string requested in go-critic#1381
go generate was needed to update the rulesdata.go file. Once updated make docs updated the advice given in https://go-critic.com/overview.html#dynamicfmtstring
alexandear
suggested changes
Nov 8, 2024
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
|
@alexandear I've merged in your suggestions, sorry I didn't catch that the first time. Feel free to approve and merge when ready. |
|
See #1437 (comment) |
alexandear
approved these changes
Nov 21, 2024
Afterous
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
If this PR is accepted, I believe it will fix the issue reported here.
Please let me know if there is anything else I can update (e.g. alter .github/workflow/doc.yaml to fail if go generate wasn't ran and a diff is detected).