Fix global-context test leakage #1317
Merged
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the global context leaks some of the values which are setup by: 1. Setting the previous context value if one existed and none were passed in when overriding it in tests 2. Doing the overrides in `before` and `after` instead of `beforeEach` and `afterEach`, since tests can run in arbitrary order. This PR fixes both of these issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the global context leaks some of the values which are setup by:
in when overriding it in tests
beforeandafterinstead ofbeforeEachand
afterEach, since tests can run in arbitrary order.This PR fixes both of these issues.