Fixes VM Babel plugin generation in browsers #1290
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
bugfix/fix-preset-usage-in-browsers
branch
from
de2c51f to
c7a71da
Compare
Currently, attempting to use `@glimmer/vm-babel-plugins` in browsers with standard build tooling fails due to the dynamic `require` that Babel itself does with the resolved paths. This change provides an option that allows us to load the plugins directly, which means that they will be bundled properly.
pzuraq
force-pushed
the
bugfix/fix-preset-usage-in-browsers
branch
from
c7a71da to
7321942
Compare
rwjblue
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, attempting to use
@glimmer/vm-babel-pluginsin browsers withstandard build tooling fails due to the dynamic
requirethat Babelitself does with the resolved paths. This change provides an option that
allows us to load the plugins directly, which means that they will be
bundled properly.