Make defaultId function more robust #1261
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `defaultId` function attempts to load the `crypto` module when in Node. However, it uses `require` directly, which may be clobbered by AMD require (in the case of Ember). This was previously handled by using Babel transforms, but that solution is somewhat brittle. This updates the logic to check for the `module` global instead, and defers to it if it exists, before checking for `require`.
rwjblue
approved these changes
Feb 6, 2021
|
Can you cross link any issues that this fixes? |
|
Superseded by #1262 |
|
Just to note, this PR did not solve any specific issue, it was related to the refactoring for the build pipeline in Ember. |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
defaultIdfunction for templates attempts to load thecryptomodulewhen in Node. However, it uses
requiredirectly, which may beclobbered by AMD require (in the case of Ember). This was previously
handled by using Babel transforms, but that solution is somewhat
brittle. This updates the logic to check for the
moduleglobalinstead, and defers to it if it exists, before checking for
require.