Fix cleaning relative links cache key #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardoporreca
commented
Mar 7, 2023
riccardoporreca
commented
Mar 7, 2023
Comment on lines
+96
to
100
| if type == :external | ||
| urls_detected = urls_detected.transform_keys do |url| | ||
| cleaned_url(url) | ||
| end | ||
| end |
There was a problem hiding this comment.
Actually, I think we may want to only avoid escape_unescape for the external links, since the other part of cleaned_url that handles trailing "/", "#", "?" would still be relevant for internal links. Any input on this @gjtorikian?
If we keep part of cleaned_url for internal links, we should probably also include it to add_internal for consistency, similar to what is done for add_external
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #792 (comment)