Test the new integrated rb-sys #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjtorikian
force-pushed
the
test-new-integrated-rb-sys
branch
2 times, most recently
from
e862163
to
a7f7aa8
Compare
|
0.9.63 has been released which officially releases this! |
Heck yeah, thank you! |
gjtorikian
force-pushed
the
test-new-integrated-rb-sys
branch
from
a7f7aa8
to
9d18494
Compare
gjtorikian
force-pushed
the
test-new-integrated-rb-sys
branch
from
0dc6515
to
a6161ca
Compare
|
Looks like they already match in your code. So I'm wondering why |
|
This diff should fix it: diff --git i/commonmarker.gemspec w/commonmarker.gemspec
index a45619e..51b564b 100644
--- i/commonmarker.gemspec
+++ w/commonmarker.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
# https://github.com/rubygems/rubygems/pull/5852#issuecomment-1231118509
spec.required_rubygems_version = ">= 3.3.22"
- spec.files = ["LICENSE.txt", "README.md", "Cargo.lock"]
+ spec.files = ["LICENSE.txt", "README.md", "Cargo.lock", "Cargo.toml"]
spec.files += Dir.glob("lib/**/*.rb")
spec.files += Dir.glob("ext/**/*.{rs,toml,lock,rb}")
spec.bindir = "exe" |
thanks! |
gjtorikian
force-pushed
the
test-new-integrated-rb-sys
branch
6 times, most recently
from
29bcc48
to
3d14d7a
Compare
gjtorikian
force-pushed
the
test-new-integrated-rb-sys
branch
from
5adc2eb
to
a835c75
Compare
gjtorikian
force-pushed
the
test-new-integrated-rb-sys
branch
3 times, most recently
from
76656d4
to
3d0769c
Compare
Commonmarker currently has three different test suites related to the gem build: 1. The compilation output is tested 2. The gem can be installed on another platform 3. A generic version of the gem can be installed on a platform with sufficient Ruby/Rust tooling Of these, only the first is the most relevant. 2 suggests an error in the build pipeline, and 3 opens the door to supporting platforms that are uncommon. In order to minimize support work on my end, I'm going to nix the last two tests; as well, I can abstract the first test into a GitHub Action for other oxidizers to use.
gjtorikian
force-pushed
the
test-new-integrated-rb-sys
branch
from
76656d4
to
7fd37da
Compare
|
BIG 🟥 diff, love it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref oxidize-rb/rb-sys#144