Update GFM release to 0.29.0.gfm.2
#148
Merged
+627
−744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @gjtorikian!
We just pushed a new release to cmark-gfm, and it'd be cool to be able to use it in commonmarker. Looking over at the changes introduced, looks like we'll also be including changes introduced
0.29.0.gfm.1
, which fixes a security vulnerability.I generated this PR via the following:
and then opened this PR.
Skimming the diff, this seems to have worked just fine and dandy; all the footnote changes I've worked in have made it in.
In addition, it looks like:
ext/commonmarker/ext_scanners.c
andext/commonmarker/table.c
are associated with this pull request github/cmark-gfm@85d8952
Thanks for taking a look!
edit: I realized that of course there was a footnotes test. I fixed the output check for
.to_html
/render_html
but figured that updating theHtmlRenderer
could be left outside of the scope of this PR.I also took the liberty of bumping the version to
0.23.2
, on the assumption that there is no major API change fromcommonmarker
's POV.