Replace use of mktemp #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses NamedTemporaryFile with delete=False to replace the one use of the deprecated mktemp function in smmap (reported in gitpython-developers#41). This avoids the race condition inherent to mktemp, as the file is named and created together in a way that is effectively atomic. Because NamedTemporaryFile is not being used to automatically delete the file, it use and cleanup are unaffected by the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
This uses
NamedTemporaryFilewithdelete=Falseto replace the one use of the deprecatedmktempfunction in smmap (reported in #41).This avoids the race condition inherent to
mktemp, as the file is named and created together in a way that is effectively atomic.Because
NamedTemporaryFileis not being used to automatically delete the file, it use and cleanup are unaffected by the change.(This PR is conceptually related to gitpython-developers/GitPython#1770.)