Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace xfail with gc.collect in TestSubmodule.test_rename #1767

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Replace xfail with gc.collect in TestSubmodule.test_rename #1767

merged 2 commits into from
Dec 12, 2023

Commits on Dec 12, 2023

  1. Remove TestSubmodule.test_rename xfail mark 

    This is to clearly establish the failure still occurs (since we do
not have strict=True set). It is in preparation for working around
the problems with a call to gc.collect().

See 82c361e and 0b7ee17 for context.
    @EliahKagan
    EliahKagan committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f62df52 View commit details
    Browse the repository at this point in the history

  2. Replace xfail with gc.collect in TestSubmodule.test_rename 

    Like the xfail was, this is conditional, being done only in the
specific situation the PermissionError occurs. Besides that it does
not always run even on Windows (only in 3.12 and later), this
resembles various other conditional and non-conditional gc.collect
calls.

It had previously appeared to me that two calls to gc.collect were
required, but I am unable to reproduce that. It may have been
specific to how I was running it on my system at that time. The
need for only one call may have been brought about by changes to
the code in the mean time, but I have tested that only one call
appears required even without the changes in gitpython-developers#1765.
    @EliahKagan
    EliahKagan committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    b66be7c View commit details
    Browse the repository at this point in the history