Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify some Git.execute kill_after_timeout limitations #1761

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Clarify some Git.execute kill_after_timeout limitations #1761

merged 2 commits into from
Dec 10, 2023

Commits on Dec 10, 2023

  1. Document more Git.execute kill_after_timeout limitations 

    See discussion in gitpython-developers#1756.
    @EliahKagan
    EliahKagan committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    f42a63b View commit details
    Browse the repository at this point in the history

  2. Avoid making it look like kill_process works on Windows 

    This changes the code in Git.execute's local kill_process function,
which it uses as the timed callback for kill_after_timeout, to
remove code that is unnecessary because kill_process doesn't
support Windows, and to avoid giving the false impression that its
code could be used unmodified on Windows without serious problems.

- Raise AssertionError explicitly if it is called on Windows. This
  is done with "raise" rather than "assert" so its behavior doesn't
  vary depending on "-O".

- Don't pass process creation flags, because they were 0 except on
  Windows.

- Don't fall back to SIGTERM if Python's signal module doesn't know
  about SIGKILL. This was specifically for Windows which has no
  SIGKILL.

See gitpython-developers#1756 for discussion.
    @EliahKagan
    EliahKagan committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    2f017ac View commit details
    Browse the repository at this point in the history