Commits on Sep 2, 2023

1. util: close lockfile after opening successfully …

   Otherwise, this will leak file handles and can be a problem in Windows.
   Also, `closefd=true` is the default here, so need to pass it explicitly.
   
   Regression from gitpython-developers#1619.
   
   I noticed after [our tests started raising `ResourceWarning`][1].
   
   ```python
   Traceback (most recent call last):
     File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/git/util.py", line 938, in _obtain_lock_or_raise
       open(lock_file, mode='w', closefd=True)
   ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/pytest-of-runner/pytest-0/popen-gw0/external0/project.git/.git/config.lock' mode='w' encoding='UTF-8'>
   ```
   
   [1]: https://github.com/iterative/dvc/actions/runs/6055520480/job/16434544764#step:6:869

   

   skshetry committed Sep 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 3e829eb
   • Browse repository at this point

   Copy the full SHA

   3e829eb View commit details

   Browse the repository at this point in the history