Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some resource leaks by open file handles #1532

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix some resource leaks by open file handles #1532

merged 1 commit into from
Jan 9, 2023

Conversation

marlamb
Copy link
Contributor

@marlamb marlamb commented Jan 8, 2023

No description provided.

@marlamb marlamb force-pushed the feature/reduce-resource-leaks branch from 752dd1a to d3dbe6c Compare January 8, 2023 23:05
@marlamb marlamb force-pushed the feature/reduce-resource-leaks branch from d3dbe6c to e500466 Compare January 8, 2023 23:10
@Byron Byron added this to the v3.1.31 - Bugfixes milestone Jan 9, 2023
@Byron
Copy link
Member

Byron commented Jan 9, 2023

Thanks a lot, amazing fixes!
It's odd that these survived so long, maybe this indicates the GitPython is mostly used in one-off commands rather than long running processes.

@Byron Byron merged commit 90c81a5 into gitpython-developers:main Jan 9, 2023
@marlamb
Copy link
Contributor Author

marlamb commented Jan 13, 2023

You are welcome, thanks for merging that quickly!

@Codym48
Copy link
Contributor

Codym48 commented Feb 15, 2023

Thank you for committing this @marlamb and merging it @Byron!

(We only tripped over one of these after we enabled filterwarnings("error") and executed the pytest suite locally within a linked worktree. It didn't appear when running within the main worktree or within any CI pipeline.)

Any idea when the next release is scheduled? Can I volunteer to help?

@Byron
Copy link
Member

Byron commented Feb 15, 2023

@Codym48 Thanks for your help! It would be great if #1535 cold be merged before a release is created, it's just missing a test. You could probably submit a PR on top of that one to add it. Thank you.

@Codym48
Copy link
Contributor

Codym48 commented Feb 16, 2023

How about something like this? kfreezen#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v3.1.31 - Bugfixes
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marlamb @Byron @Codym48