Fixes $github-pages health-check NoMethodError
#878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
Removed in Ruby 3.2.0. https://www.reddit.com/r/ruby/comments/1196wti/psa_and_a_little_rant_fileexists_direxists/
|
Ah neat! Thank you for the Reddit threadAlso hi Parker! Thanks for the merge. On Apr 2, 2023, at 11:47 AM, Parker Moore ***@***.***> wrote:
@parkr approved this pull request.
Removed in Ruby 3.2.0. https://www.reddit.com/r/ruby/comments/1196wti/psa_and_a_little_rant_fileexists_direxists/
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
yoannchaudet
approved these changes
Dec 28, 2023
|
Thank you! |
another-rex
pushed a commit
to google/osv-scanner
that referenced
this pull request
Feb 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://togithub.com/github/pages-gem) | `"~> 228"` -> `"~> 230"` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v230`](https://togithub.com/github/pages-gem/releases/tag/v230) [Compare Source](https://togithub.com/github/pages-gem/compare/v229...v230) #### What's Changed - Bump docker/login-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#907 - Bump docker/build-push-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#905 - Bump docker/setup-buildx-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#906 - Bump Jekyll to 3.9.5 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#908 **Full Changelog**: github/pages-gem@v229...v230 ### [`v229`](https://togithub.com/github/pages-gem/releases/tag/v229) [Compare Source](https://togithub.com/github/pages-gem/compare/v228...v229) #### What's Changed - Bump docker/metadata-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#889 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#888 - Fixes `$github-pages health-check` NoMethodError by [@​edward](https://togithub.com/edward) in [github/pages-gem#878 - Support Ruby 3.2+, fixes [#​879](https://togithub.com/github/pages-gem/issues/879) by [@​fulldecent](https://togithub.com/fulldecent) in [github/pages-gem#880 - Create publish-gem.yml by [@​tsusdere](https://togithub.com/tsusdere) in [github/pages-gem#898 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#900 - Enable multi arch docker image build by [@​rngtng](https://togithub.com/rngtng) in [github/pages-gem#884 - Bring back proper support for Ruby 3.x by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#901 - Bump dependencies (patch and minor only) by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#902 - Fix release script by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#903 - Another publish script fix by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#904 #### New Contributors - [@​edward](https://togithub.com/edward) made their first contribution in [github/pages-gem#878 - [@​fulldecent](https://togithub.com/fulldecent) made their first contribution in [github/pages-gem#880 - [@​tsusdere](https://togithub.com/tsusdere) made their first contribution in [github/pages-gem#898 - [@​rngtng](https://togithub.com/rngtng) made their first contribution in [github/pages-gem#884 **Full Changelog**: github/pages-gem@v228...v229 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
werdnanoslen
pushed a commit
to trussworks/research-design-playbook
that referenced
this pull request
Feb 29, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://togithub.com/github/pages-gem) | `"~> 228"` -> `"~> 231"` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v231`](https://togithub.com/github/pages-gem/releases/tag/v231) [Compare Source](https://togithub.com/github/pages-gem/compare/v230...v231) #### What's Changed - Revert jekyll-relative-links to 0.6.1 and add a test by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#910 **Full Changelog**: github/pages-gem@v230...v231 ### [`v230`](https://togithub.com/github/pages-gem/releases/tag/v230) [Compare Source](https://togithub.com/github/pages-gem/compare/v229...v230) #### What's Changed - Bump docker/login-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#907 - Bump docker/build-push-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#905 - Bump docker/setup-buildx-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#906 - Bump Jekyll to 3.9.5 by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#908 **Full Changelog**: github/pages-gem@v229...v230 ### [`v229`](https://togithub.com/github/pages-gem/releases/tag/v229) [Compare Source](https://togithub.com/github/pages-gem/compare/v228...v229) #### What's Changed - Bump docker/metadata-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#889 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#888 - Fixes `$github-pages health-check` NoMethodError by [@​edward](https://togithub.com/edward) in [github/pages-gem#878 - Support Ruby 3.2+, fixes [#​879](https://togithub.com/github/pages-gem/issues/879) by [@​fulldecent](https://togithub.com/fulldecent) in [github/pages-gem#880 - Create publish-gem.yml by [@​tsusdere](https://togithub.com/tsusdere) in [github/pages-gem#898 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [github/pages-gem#900 - Enable multi arch docker image build by [@​rngtng](https://togithub.com/rngtng) in [github/pages-gem#884 - Bring back proper support for Ruby 3.x by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#901 - Bump dependencies (patch and minor only) by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#902 - Fix release script by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#903 - Another publish script fix by [@​yoannchaudet](https://togithub.com/yoannchaudet) in [github/pages-gem#904 #### New Contributors - [@​edward](https://togithub.com/edward) made their first contribution in [github/pages-gem#878 - [@​fulldecent](https://togithub.com/fulldecent) made their first contribution in [github/pages-gem#880 - [@​tsusdere](https://togithub.com/tsusdere) made their first contribution in [github/pages-gem#898 - [@​rngtng](https://togithub.com/rngtng) made their first contribution in [github/pages-gem#884 **Full Changelog**: github/pages-gem@v228...v229 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/trussworks/research-design-playbook). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
$github-pages health-checkwill cause aNoMethodErrorexception becauseFile.exists?is not defined.This patch updates it to use
File.exist?which is what I think was intended.