chore: update rule meta to satisfiy lint rules #621
Merged
+183
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates a few things in rule meta so the linter is happy: - Some descriptions didn't follow the naming convention (`enforce`, `require`, etc) - Some rules had no `type`, so these were set to `problem` - Some rules had no `recommended`, so these were set to if they are in the recommended config or not - Message IDs have been used instead of messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates a few things in rule meta so the linter is happy:
enforce,require, etc)type, so these were set toproblemrecommended, so these were set to if they are in the recommended config or notthese didn't happen in CI but did error locally for whatever reason
edit:
so it turns out the eslint-plugin-eslint-plugin rules haven't been running against the rule files
for whatever reason,
ast.sourceTypeends up as"module"inside the plugin, so it tries to look for ESM exports and doesn't find any. so the rules never run