Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update no-then.md #503

Merged
merged 3 commits into from Feb 5, 2024
Merged

Update no-then.md #503

merged 3 commits into from Feb 5, 2024

Commits on Feb 3, 2024

  1. Update no-then.md 

    The 'improved code' after linting was unnecessarily complex introducing a named variable across multiple lines for no reason which made it look better to keep using `then`. A bit surprising.

Previous catch example was code which didn't differentiate between failing case (which is now a deliberate null) and undefined case (which is often the result of an error).
    @cefn
    cefn committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    72c0daa View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. closing bracket

    @theinterned
    theinterned committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    d841784 View commit details
    Browse the repository at this point in the history

  2. closing fence

    @theinterned
    theinterned committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8abd830 View commit details
    Browse the repository at this point in the history