Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into releases/v3 #2142

Merged
merged 21 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
77be28f
Add feature flag for disabling Java buildless
henrymercer Feb 12, 2024
4e5f9c0
Introduce a rollback mechanism for Java buildless
henrymercer Feb 12, 2024
65853b9
Add e2e test for rolling back build mode
henrymercer Feb 12, 2024
db663b2
Update changelog and version after v3.24.1
github-actions[bot] Feb 13, 2024
cf10f87
Update checked-in dependencies
github-actions[bot] Feb 13, 2024
3935424
Remove some inadvertently checked in build files
henrymercer Feb 13, 2024
057a9cb
Merge pull request #2134 from github/henrymercer/remove-junk
henrymercer Feb 13, 2024
191f59f
Store generated config file in temporary directory
henrymercer Feb 13, 2024
ecdd69d
Merge pull request #2132 from github/mergeback/v3.24.1-to-main-e675ced7
dbartol Feb 13, 2024
bc64d12
Merge pull request #2135 from github/henrymercer/no-analyze-config
henrymercer Feb 13, 2024
427cfbe
Add backticks around branch
jsoref Feb 13, 2024
7b30fef
Add common CLI configuration error categories (#2130)
angelapwen Feb 14, 2024
c6cf6fd
Merge pull request #2138 from jsoref/update-release-branch-backticks-…
henrymercer Feb 14, 2024
eb60ca2
Merge branch 'main' into henrymercer/java-buildless-rollback
henrymercer Feb 14, 2024
729def5
Teach rebuild Action how to resolve conflicts in lib
henrymercer Feb 14, 2024
d57cf8e
Merge pull request #2140 from github/henrymercer/rebuild-resolve-conf…
henrymercer Feb 14, 2024
95d258a
Merge pull request #2129 from github/henrymercer/java-buildless-rollback
henrymercer Feb 14, 2024
f00392e
Deprecate fine-grained parallelism feature-flag
nickrolfe Feb 14, 2024
1a41e55
Merge pull request #2141 from github/nickrolfe/deprecate-ff
nickrolfe Feb 14, 2024
663c150
Update changelog for v3.24.2
github-actions[bot] Feb 15, 2024
32f8d53
Add changelog note for #2141
angelapwen Feb 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/update-release-branch.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def open_pr(

# Start constructing the body text
body = []
body.append(f'Merging {source_branch_short_sha} into {target_branch}.')
body.append(f'Merging {source_branch_short_sha} into `{target_branch}`.')

body.append('')
body.append(f'Conductor for this PR is @{conductor}.')
Expand Down Expand Up @@ -92,7 +92,7 @@ def open_pr(
'branch to resolve the merge conflicts.')
body.append(' - [ ] Ensure the CHANGELOG displays the correct version and date.')
body.append(' - [ ] Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.')
body.append(f' - [ ] Check that there are not any unexpected commits being merged into the {target_branch} branch.')
body.append(f' - [ ] Check that there are not any unexpected commits being merged into the `{target_branch}` branch.')
body.append(' - [ ] Ensure the docs team is aware of any documentation changes that need to be released.')

if not is_primary_release:
Expand Down
89 changes: 89 additions & 0 deletions .github/workflows/__build-mode-rollback.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .github/workflows/debug-artifacts-failure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
shell: bash
run: |
LANGUAGES="cpp csharp go java javascript python"
pushd "./my-debug-artifacts"
cd "./my-debug-artifacts"
echo "Artifacts from run:"
for language in $LANGUAGES; do
echo "- Checking $language"
Expand All @@ -82,6 +82,5 @@ jobs:
exit 1
fi
done
popd
env:
GO111MODULE: auto
17 changes: 17 additions & 0 deletions .github/workflows/rebuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,23 @@ jobs:
gh pr edit --repo github/codeql-action "$PR_NUMBER" \
--remove-label "Rebuild"

- name: Merge in changes from base branch
env:
BASE_BRANCH: ${{ github.event.pull_request.base.ref }}
run: |
git fetch origin "$BASE_BRANCH"

# Allow merge conflicts in `lib`, since rebuilding should resolve them.
git merge "origin/$BASE_BRANCH" || echo "Merge conflicts detected"

# Check for merge conflicts outside of `lib`. Disable git diff's trailing whitespace check
# since `node_modules/@types/semver/README.md` fails it.
if git -c core.whitespace=-trailing-space diff --check | grep --invert-match '^lib/'; then
echo "Merge conflicts detected outside of lib/ directory. Please resolve them manually."
git -c core.whitespace=-trailing-space diff --check | grep --invert-match '^lib/' || true
exit 1
fi

- name: Compile TypeScript
run: |
npm install
Expand Down
7 changes: 6 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# Ignore for example failing-tests.json from AVA
node_modules/.cache
node_modules/.cache/
# Java build files
.gradle/
*.class
# macOS
.DS_Store
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th

Note that the only difference between `v2` and `v3` of the CodeQL Action is the node version they support, with `v3` running on node 20 while we continue to release `v2` to support running on node 16. For example `3.22.11` was the first `v3` release and is functionally identical to `2.22.11`. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.

## 3.24.2 - 15 Feb 2024

- Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. [#2141](https://github.com/github/codeql-action/pull/2141)

## 3.24.1 - 13 Feb 2024

- Update default CodeQL bundle version to 2.16.2. [#2124](https://github.com/github/codeql-action/pull/2124)
Expand Down
2 changes: 1 addition & 1 deletion lib/analyze.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze.js.map

Large diffs are not rendered by default.

116 changes: 81 additions & 35 deletions lib/cli-errors.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.