Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete analysis after uploading #1981

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Delete analysis after uploading #1981

merged 3 commits into from
Nov 16, 2023

Commits on Nov 10, 2023

  1. Delete analysis after uploading 

    The analysis is purposefully failing. We don't want a failed analysis
sitting in the security center since this can cause some internal
checks to erroneously fail.
    @aeisenberg
    aeisenberg committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    04451e0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Address comments from review 

    - Change error messages.
- Use logger instead of core
- throw Error instead of write error message
    @aeisenberg
    aeisenberg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    df9b50e View commit details
    Browse the repository at this point in the history

  2. Use delay instead of wait 

    Need to also change the signature of delay to allow this to happen.
    @aeisenberg
    aeisenberg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4e80a80 View commit details
    Browse the repository at this point in the history