Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of fatal CLI errors #1795

Merged
merged 13 commits into from
Jul 24, 2023
Merged

Improve handling of fatal CLI errors #1795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
76b2afa
Display the CLI's no code found error for CodeQL 2.12.4+
henrymercer Jul 20, 2023
21c9267
Capture the details of fatal errors
henrymercer Jul 20, 2023
e94e15d
Fix extra whitespace in `CommandInvocationError`
henrymercer Jul 20, 2023
c844189
Add additional tests for `database finalize` behavior
henrymercer Jul 20, 2023
0f871fa
Improve `CommandInvocationError` message
henrymercer Jul 20, 2023
65a297b
Display the error message on one line if possible
henrymercer Jul 21, 2023
a3ef0b9
Include fatal error context on a single line where possible
henrymercer Jul 21, 2023
2eb34f2
Always include exit code in first line of CommandInvocationError
henrymercer Jul 21, 2023
fdedc91
Improve formatting of fatal errors
henrymercer Jul 21, 2023
9fc0c93
Add changelog note
henrymercer Jul 21, 2023
5bbe7a2
Add test for summarizing several fatal errors
henrymercer Jul 21, 2023
47952bf
Remove generated files associated with deleted code
henrymercer Jul 21, 2023
7197f58
Add JSDoc for `extractFatalErrors`
henrymercer Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th

## [UNRELEASED]

No user facing changes.
- Improve the handling of fatal errors from the CodeQL CLI. [#1795](https://github.com/github/codeql-action/pull/1795)

## 2.21.0 - 19 Jul 2023

Expand Down
119 changes: 106 additions & 13 deletions lib/codeql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map
View file
Open in desktop

Large diffs are not rendered by default.

68 changes: 65 additions & 3 deletions lib/codeql.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.test.js.map
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 0 additions & 22 deletions lib/error-matcher.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lib/error-matcher.js.map
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions lib/error-matcher.test.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lib/error-matcher.test.js.map
View file
Open in desktop

This file was deleted.