Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid parsing SARIF file when workaround for duplicate notification locations is disabled #1697

Merged
merged 5 commits into from
May 25, 2023
Merged

Avoid parsing SARIF file when workaround for duplicate notification locations is disabled #1697

merged 5 commits into from
May 25, 2023

Conversation

kaeluka
Copy link
Contributor

@kaeluka kaeluka commented May 24, 2023 •
edited

DISABLE_DUPLICATE_LOCATION_FIX - this is to avoid needless crashes on
large sarif files

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@kaeluka
move check to calling function
3100e1e 
DISABLE_DUPLICATE_LOCATION_FIX - this is to avoid needless crashes on
large sarif files
kaeluka
kaeluka commented May 24, 2023
View reviewed changes
src/util.ts Show resolved Hide resolved
@kaeluka
Copy link
Contributor Author

kaeluka commented May 24, 2023

[ ] Confirm this change is backwards compatible with existing workflows.

@henrymercer — I think it is backwards compatible, but I'm not sure I'm right. Do you have an opinion?

henrymercer
henrymercer previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix! For posterity, I suggest we rename this PR to something like "Avoid parsing SARIF file when workaround for duplicate notification locations is disabled".

@henrymercer
Copy link
Contributor

@henrymercer — I think it is backwards compatible, but I'm not sure I'm right. Do you have an opinion?

Agreed 👍

@kaeluka kaeluka marked this pull request as ready for review May 24, 2023 12:16
@kaeluka kaeluka requested a review from a team as a code owner May 24, 2023 12:16
@tausbn tausbn changed the title move check to calling function Avoid parsing SARIF file when workaround for duplicate notification locations is disabled May 24, 2023
@henrymercer
Copy link
Contributor

#1696 fixes the broken PR checks. Once that's in, we should be able to merge this.

@kaeluka
Copy link
Contributor Author

kaeluka commented May 25, 2023

@henrymercer From my viewpoint, this could be merged now — it seems like you merged in the fix to get tests to pass. Let's merge it?

@henrymercer
Copy link
Contributor

I agree this is good to go. I'll merge this now since you're happy with it, but in the future feel free to merge or auto-merge yourself once you're happy and after an approving review.

@henrymercer henrymercer merged commit 5f061ca into main May 25, 2023
325 checks passed
@henrymercer henrymercer deleted the fixInvalidNotifications-shortcut branch May 25, 2023 09:45
@github-actions github-actions bot mentioned this pull request May 25, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn left review comments

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaeluka @henrymercer @tausbn