Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Swift PR Checks on nightly-latest CLI #1696

Merged
merged 12 commits into from
May 24, 2023
Merged

Fix Swift PR Checks on nightly-latest CLI #1696

merged 12 commits into from
May 24, 2023

Commits on May 23, 2023

  1. Add custom setup-swift workflow to PR check 

    Now that Swift analysis is on by default, we are autodetecting Swift, but Swift is not set up in this workflow. This change adds the Swift setup workflow.
    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ebb84c5 View commit details
    Browse the repository at this point in the history

  2. Unconditionally run setup-swift 

    We now can (and need to) to run these steps without the environment variable being set in the other PR checks.
    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0df283c View commit details
    Browse the repository at this point in the history

  3. Pass Swift experimental flag to debug artifacts PR check 

    We cannot remove the conditional in the `setup-swift` workflow because it will fail to find the Swift extractor in prior versions without the experimental flag set. For now we replace the conditional and pass the experimental flag to the failing PR check.
    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    f2bad39 View commit details
    Browse the repository at this point in the history

  4. Only run setup-swift if found in codeql resolve languages

    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    424b55e View commit details
    Browse the repository at this point in the history

  5. Stop setting experimental flag on latest CLI

    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    91268d3 View commit details
    Browse the repository at this point in the history

  6. Stop setting experimental flag in debug artifacts

    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    3ee1898 View commit details
    Browse the repository at this point in the history

  7. Prevent running steps on Windows, fix typo

    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    25fbb22 View commit details
    Browse the repository at this point in the history

  8. Fix typos

    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    27af7f7 View commit details
    Browse the repository at this point in the history

  9. Only run setup-swift for debug artifact if on nightly-latest

    @angelapwen
    angelapwen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4418543 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Update .github/actions/setup-swift/action.yml 

    Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
    @angelapwen @aeisenberg
    angelapwen and aeisenberg committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f83f109 View commit details
    Browse the repository at this point in the history

  2. Give init in workflow an id

    @angelapwen
    angelapwen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8564eab View commit details
    Browse the repository at this point in the history

  3. Check Swift autodetect on nightly-latest

    @angelapwen
    angelapwen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4b96e7b View commit details
    Browse the repository at this point in the history