Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundle to 2.12.4 #1561

Merged
merged 7 commits into from Mar 9, 2023
Merged

Update bundle to 2.12.4 #1561

merged 7 commits into from Mar 9, 2023

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented Mar 6, 2023

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer
Copy link
Contributor

I've pushed a fix for a bug in #1527 that meant we passed a --qlconfig=undefined argument when there was no qlconfig file. I've also merged in main to bring in #1560 which should fix the issues with setup-swift.

@aeisenberg
Copy link
Contributor

Thanks for the fix, @henrymercer. I've confirmed that it works locally. I created a PR against main to fix it there. #1564

@dbartol dbartol marked this pull request as ready for review March 9, 2023 14:44
@dbartol dbartol requested a review from a team as a code owner March 9, 2023 14:44
@dbartol dbartol requested a review from henrymercer March 9, 2023 14:51
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(My commits are merged into main so I'm not signing off on my own code)

@dbartol dbartol enabled auto-merge March 9, 2023 15:03
@dbartol dbartol merged commit e12a2ec into main Mar 9, 2023
298 checks passed
@dbartol dbartol deleted the dbartol/bundle-2.12.4 branch March 9, 2023 15:22
@github-actions github-actions bot mentioned this pull request Mar 10, 2023
6 tasks
@mirabilos
Copy link

I've pushed a fix for a bug in #1527 that meant we passed a --qlconfig=undefined argument

Erm, yes, I’m running into this because the bundle has been updated (compared to the previous run of the action). But there’s no new release; how do I get the builds working again?

@mirabilos
Copy link

Ah well, reverting to an earlier version codeql-bundle-20230105 worked.

@henrymercer
Copy link
Contributor

Erm, yes, I’m running into this because the bundle has been updated (compared to the previous run of the action). But there’s no new release; how do I get the builds working again?

Hi @mirabilos — this fix was released in version 2.2.6 of the CodeQL Action. Please let us know if you still aren't able to use the latest bundle.

@mirabilos
Copy link

mirabilos commented Mar 20, 2023 via email

@henrymercer
Copy link
Contributor

We release the CodeQL Action using git tags, and release CodeQL Action Bundles using GitHub Releases. It looks like the tool you're using is only picking up on the GitHub Releases. We'd recommend configuring your workflow to use the v2 tag (for example uses: github/codeql-action/init@v2). We update this tag with each release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants