Apply suggestions from code review

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
github · Feb 9, 2024 · ac030dd · ac030dd
1 parent d3f9862
commit ac030dd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
 
 ## [UNRELEASED]
 
-- The upload-sarif action should not fail if it can't write to the telemetry api endpoint [#2121](https://github.com/github/codeql-action/pull/2121)
+- The CodeQL action no longer fails if it can't write to the telemetry api endpoint. [#2121](https://github.com/github/codeql-action/pull/2121)
 
 ## 3.24.0 - 02 Feb 2024
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "codeql",
-  "version": "3.25.0",
+  "version": "3.24.1",
   "private": true,
   "description": "CodeQL action",
   "scripts": {

diff --git a/src/status-report.ts b/src/status-report.ts
@@ -294,12 +294,10 @@ const INCOMPATIBLE_MSG =
  * as failed if the status report failed. This is only expected to be used
  * when sending a 'starting' report.
  *
- * This API it calls is private and it is not critical that it succeed:
+ * The `/code-scanning/analysis/status` endpoint is internal and not critical that it succeeds:
  * https://github.com/github/codeql/issues/15462#issuecomment-1919186317
  *
- * Do not worry about whether a report is/isn't submitted.
- * Just go about your business.
- * The side effects of this call are not relevant to your program.
+ * Failures while calling this endpoint are logged as warings.
  */
 export async function sendStatusReport<S extends StatusReportBase>(
   statusReport: S,

diff --git a/src/upload-lib.ts b/src/upload-lib.ts
@@ -17,9 +17,9 @@ import * as util from "./util";
 import { SarifFile, ConfigurationError, wrapError } from "./util";
 
 const GENERIC_403_MSG =
-  "The repo on which this action is running is not opted-in to CodeQL code scanning.";
+  "The repo on which this action is running has not opted-in to CodeQL code scanning.";
 const GENERIC_404_MSG =
-  "Not authorized to use the CodeQL code scanning feature on this repo.";
+  "The CodeQL code scanning feature is forbidden on this repository.";
 
 // Takes a list of paths to sarif files and combines them together,
 // returning the contents of the combined sarif file.