Merge pull request #2246 from github/koesie10/remove-incorrect-log

Remove incorrect log message
github · Apr 17, 2024 · 82edfe2 · 82edfe2
2 parents 8786e1f + 5d73b1b
commit 82edfe2
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 14 deletions.
diff --git a/lib/upload-lib.js b/lib/upload-lib.js
diff --git a/lib/upload-lib.js.map b/lib/upload-lib.js.map
diff --git a/lib/upload-lib.test.js b/lib/upload-lib.test.js
diff --git a/lib/upload-lib.test.js.map b/lib/upload-lib.test.js.map
diff --git a/src/upload-lib.test.ts b/src/upload-lib.test.ts
@@ -42,7 +42,6 @@ test("validate correct payload used for push, PR merge commit, and PR head", asy
     undefined,
     ["CodeQL", "eslint"],
     "mergeBaseCommit",
-    getRunnerLogger(true),
   );
   // Not triggered by a pull request
   t.falsy(pushPayload.base_ref);
@@ -66,7 +65,6 @@ test("validate correct payload used for push, PR merge commit, and PR head", asy
     undefined,
     ["CodeQL", "eslint"],
     "mergeBaseCommit",
-    getRunnerLogger(true),
   );
   // Uploads for a merge commit use the merge base
   t.deepEqual(prMergePayload.base_ref, "refs/heads/master");
@@ -84,7 +82,6 @@ test("validate correct payload used for push, PR merge commit, and PR head", asy
     undefined,
     ["CodeQL", "eslint"],
     "mergeBaseCommit",
-    getRunnerLogger(true),
   );
   // Uploads for the head use the PR base
   t.deepEqual(prHeadPayload.base_ref, "refs/heads/master");

diff --git a/src/upload-lib.ts b/src/upload-lib.ts
@@ -421,9 +421,7 @@ export function buildPayload(
   environment: string | undefined,
   toolNames: string[],
   mergeBaseCommitOid: string | undefined,
-  logger: Logger,
 ) {
-  logger.info(`Combining SARIF files using CLI`);
   const payloadObj = {
     commit_oid: commitOid,
     ref,
@@ -537,7 +535,6 @@ async function uploadFiles(
     environment,
     toolNames,
     await actionsUtil.determineMergeBaseCommitOid(),
-    logger,
   );
 
   // Log some useful debug info about the info