Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CMARK_NODE_FOOTNOTE_DEFINITION literal value. #336

Merged
merged 1 commit into from Jul 20, 2023

Conversation

ioquatix
Copy link

@ioquatix ioquatix commented Jun 16, 2023

In addition, fix a bug where the length of the literal value was calculated AFTER the actual literal string (null terminated) was allocated.

Before this fix:

# footnote.string_content
"hi]: "

After this fix:

# footnote.string_content
"hi"

src/node.c Outdated Show resolved Hide resolved
src/node.c Outdated Show resolved Hide resolved
@ioquatix ioquatix force-pushed the expose-footnote-def-literal branch 2 times, most recently from 1a4b0b9 to ab19806 Compare June 19, 2023 22:58
In addition, fix a bug where the length of the literal value was
calculated AFTER the actual literal string (null terminated) was
allocated.
@ioquatix ioquatix force-pushed the expose-footnote-def-literal branch from ab19806 to 85d2eb9 Compare June 19, 2023 22:59
@ioquatix
Copy link
Author

Sorry, there a glitch in the matrix, I've fixed the commit.

@ioquatix ioquatix changed the title Expose CMARK_NODE_FOOTNOTE_DEFINION literal value. Expose CMARK_NODE_FOOTNOTE_DEFINITION literal value. Jun 20, 2023
@anticomputer anticomputer merged commit c123e68 into github:master Jul 20, 2023
@ioquatix ioquatix deleted the expose-footnote-def-literal branch July 21, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants