First pass at removing panics in Context.JSON and Context.Render #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
=========================================
+ Coverage 93.16% 93.46% +0.3%
=========================================
Files 15 15
Lines 1288 1286 -2
=========================================
+ Hits 1200 1202 +2
+ Misses 76 74 -2
+ Partials 12 10 -2
Continue to review full report at Codecov.
|
Closed
|
Wrong branch. Please see the contribution guide. |
|
Apologies, will re-open against develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #852 - removes panics from closed streams and returns errors.
Currently a single broken pipe can bring down an entire server serving thousands of requests. The panic is too aggressive, and requires attempting to recover on every single request/response pair.
Mostly open for discussion, but I'd like to see the panics removed at this level. Thanks!