Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In the default configuration, Gin enables RedirectTrailingSlash, which allows paths with trailing slashes to work properly even in
/:param1/:param2
pattern, for example/hostname/evil.com/
.This is achieved by redirecting users to
/hostname/evil.com
using theredirectTrailingSlash
function. However, if theparam1
is empty, users are redirected to//evil.com
, browsers will automatically prepend the http(s) protocol for url starting with//
. Below is a simple vulnerable code snippet.You can observe the request being redirected to a malicious website by accessing http://localhost:8080//evil.com/ in your browser or using the curl command
curl -v http://localhost:8080//evil.com/
. This issue affects versions 1.9.1 and earlier.Below is the fix code: