Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only push net error to c.Errors and panic others errors #3587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chenyahui
Copy link

In pr: #2150, remove the panic in Render function and push all error to c.Errors.

This is to avoid panic when encountering "broken pipe -> write tcp" errors, in order to improve program performance.

However, this will also cause the program to ignore errors from json.Marshal(). When an error occurs during json.Marshal(), the client will only receive an empty http body.

Therefore, when it is a non-network error, Render() still needs to panic in order for the client to be aware of this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant