Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds cookie binding #3393

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions binding/binding.go
Expand Up @@ -85,6 +85,7 @@ var (
Uri = uriBinding{}
Header = headerBinding{}
TOML = tomlBinding{}
Cookie = cookieBinding{}
)

// Default returns the appropriate Binding instance based on the HTTP method
Expand Down
22 changes: 22 additions & 0 deletions binding/cookie.go
@@ -0,0 +1,22 @@
// Copyright 2017 Manu Martinez-Almeida. All rights reserved.
// Use of this source code is governed by a MIT style
// license that can be found in the LICENSE file.

package binding

import "net/http"

type cookieBinding struct{}

func (cookieBinding) Name() string {
return "cookie"
}

func (c cookieBinding) Bind(req *http.Request, obj any) error {
cookies := make(map[string][]string, len(req.Cookies()))
for _, cookie := range req.Cookies() {
cookies[cookie.Name] = append(cookies[cookie.Name], cookie.Value)
}

return mapFormByTag(obj, cookies, c.Name())
}
5 changes: 5 additions & 0 deletions context.go
Expand Up @@ -737,6 +737,11 @@
return c.ShouldBindWith(obj, binding.Header)
}

// ShouldBindCookie is a shortcut for c.ShouldBindWith(obj, binding.Cookie).
func (c *Context) ShouldBindCookie(obj any) error {
return c.ShouldBindWith(obj, binding.Cookie)

Check failure on line 742 in context.go

View workflow job for this annotation

GitHub Actions / ubuntu-latest @ Go 1.20 -tags nomsgpack

undefined: binding.Cookie
}

// ShouldBindUri binds the passed struct pointer using the specified binding engine.
func (c *Context) ShouldBindUri(obj any) error {
m := make(map[string][]string)
Expand Down
21 changes: 21 additions & 0 deletions context_test.go
Expand Up @@ -1825,6 +1825,27 @@ func TestContextShouldBindHeader(t *testing.T) {
assert.Equal(t, 0, w.Body.Len())
}

func TestContextShouldBindCookie(t *testing.T) {
w := httptest.NewRecorder()
c, _ := CreateTestContext(w)

c.Request, _ = http.NewRequest("POST", "/", nil)
c.Request.AddCookie(&http.Cookie{Name: "rate", Value: "8000"})
c.Request.AddCookie(&http.Cookie{Name: "domain", Value: "music"})
c.Request.AddCookie(&http.Cookie{Name: "limit", Value: "1000"})

var testCookie struct {
Rate int `cookie:"rate"`
Domain string `cookie:"domain"`
Limit int `cookie:"limit"`
}

assert.NoError(t, c.ShouldBindCookie(&testCookie))
assert.Equal(t, 8000, testCookie.Rate)
assert.Equal(t, "music", testCookie.Domain)
assert.Equal(t, 1000, testCookie.Limit)
}

func TestContextShouldBindWithQuery(t *testing.T) {
w := httptest.NewRecorder()
c, _ := CreateTestContext(w)
Expand Down
40 changes: 40 additions & 0 deletions docs/doc.md
Expand Up @@ -28,6 +28,7 @@
- [Bind Query String or Post Data](#bind-query-string-or-post-data)
- [Bind Uri](#bind-uri)
- [Bind Header](#bind-header)
- [Bind Cookie](#bind-cookie)
- [Bind HTML checkboxes](#bind-html-checkboxes)
- [Multipart/Urlencoded binding](#multiparturlencoded-binding)
- [XML, JSON, YAML, TOML and ProtoBuf rendering](#xml-json-yaml-toml-and-protobuf-rendering)
Expand Down Expand Up @@ -938,6 +939,45 @@ func main() {
}
```

### Bind Cookie

```go
package main

import (
"fmt"
"net/http"

"github.com/gin-gonic/gin"
)

type testCookie struct {
Rate int `cookie:"Rate"`
Domain string `cookie:"Domain"`
}

func main() {
r := gin.Default()
r.GET("/", func(c *gin.Context) {
h := testCookie{}

if err := c.ShouldBindCookie(&h); err != nil {
c.JSON(http.StatusOK, err)
}

fmt.Printf("%#v\n", h)
c.JSON(http.StatusOK, gin.H{"Rate": h.Rate, "Domain": h.Domain})
})

r.Run()

// client
// curl -H "rate:300" -H "domain:music" 127.0.0.1:8080/
// output
// {"Domain":"music","Rate":300}
}
```

### Bind HTML checkboxes

See the [detail information](https://github.com/gin-gonic/gin/issues/129#issuecomment-124260092)
Expand Down