Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: FreeBSD fix #3258

Merged
merged 2 commits into from Sep 20, 2023
Merged

CI: FreeBSD fix #3258

merged 2 commits into from Sep 20, 2023

Conversation

alonfaraj
Copy link
Contributor

@alonfaraj alonfaraj commented Sep 19, 2023

- Update Ubuntu make job to use latest instead of Ubuntu 20.04 and gcc-8

- change ubuntu make to latest
Copy link
Collaborator

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update Ubuntu make job to use latest instead of Ubuntu 20.04 and gcc-8

this is actually intentional, to test the older gcc 😄

@alonfaraj
Copy link
Contributor Author

this is actually intentional, to test the older gcc 😄

Oops 😅
Fixed.

@Green-Sky
Copy link
Collaborator

Do you have a test run somewhere?

@alonfaraj
Copy link
Contributor Author

Copy link
Collaborator

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets see if this is more reliable

@alonfaraj alonfaraj changed the title CI: FreeBSD fix + Ubuntu make latest CI: FreeBSD fix Sep 19, 2023
@Green-Sky Green-Sky merged commit a40f2b6 into ggerganov:master Sep 20, 2023
10 checks passed
@cebtenzzre
Copy link
Collaborator

cebtenzzre commented Sep 20, 2023

FreeBSD CI stopped working:
https://github.com/ggerganov/llama.cpp/actions/runs/6250930942/job/16970883041?pr=3200
https://github.com/ggerganov/llama.cpp/actions/runs/6251258475/job/16971987633?pr=3228

Error: Waiting for VM to become ready timed out after 120 seconds

@Green-Sky
Copy link
Collaborator

well, at least it fails fast now (instead of >2h doing nothing)

@alonfaraj
Copy link
Contributor Author

@Green-Sky
I was looking around for other solutions because seems like this action doesn't function so well.
I have found https://github.com/vmactions/freebsd-vm which seems to be more stable and didn't notice any reported issues.
I have tested it, ran 10 times in a raw, everything works as expected and looks good.
No warnings etc. like we have now.
The test are here.
You can see the 10 attempts on the right upper corner.
Let me know if you think it worth a try before we give up 😁

@Green-Sky
Copy link
Collaborator

Green-Sky commented Sep 21, 2023

hmm I took a look around, and it seems that this runner is still using macos as the "host".
Although it says that you can run qemu on macos, it says:

The FreeBSD and OpenBSD VMs run on the xhyve hypervisor (on a macOS host), while the other platforms run on the QEMU hypervisor (on a Linux host).

... maybe we should just try a linux host first, just to check.

also, seems like https://github.com/vmactions/freebsd-vm installs full on virtualbox. I would prefer qemu. 😄

@cebtenzzre
Copy link
Collaborator

@alonfaraj
Copy link
Contributor Author

@cebtenzzre nothing 😅
It tends to work most of the times by looking at the actions history.
Seems to be generally unstable.

@Green-Sky
Copy link
Collaborator

yea it just flakes sometimes, just rerun it for now.

@slaren
Copy link
Collaborator

slaren commented Sep 22, 2023

The difference between a successful run and a failed run seems to be this error:

2023-09-22T16:02:27.0894530Z dyld[1311]: Library not loaded: '/usr/local/opt/capstone/lib/libcapstone.4.dylib'
2023-09-22T16:02:27.0996490Z   Referenced from: '/Users/runner/work/_temp/82a0ebe7-06e4-439b-93ce-a0f44424e855/bin/qemu'
2023-09-22T16:02:27.1029200Z   Reason: tried: '/usr/local/opt/capstone/lib/libcapstone.4.dylib' (no such file), '/usr/local/lib/libcapstone.4.dylib' (no such file), '/usr/lib/libcapstone.4.dylib' (no such file), '/usr/local/Cellar/capstone/5.0.1/lib/libcapstone.4.dylib' (no such file), '/usr/local/lib/libcapstone.4.dylib' (no such file), '/usr/lib/libcapstone.4.dylib' (no such file)

pkrmf pushed a commit to morlockstudios-com/llama.cpp that referenced this pull request Sep 26, 2023
* - freebsd ci: use qemu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants