Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Parse enable directives & SHADER-F16 support #5701

Open
wants to merge 44 commits into
base: trunk
Choose a base branch
from
Open

feature: Parse enable directives & SHADER-F16 support #5701

wants to merge 44 commits into from
+1,191 −38

Conversation

FL33TW00D
Copy link
Contributor

@FL33TW00D FL33TW00D commented May 13, 2024 •
edited

References:
F16 is available in >=SM6.2: https://github.com/microsoft/DirectXShaderCompiler/wiki/16-Bit-Scalar-Types

@FL33TW00D FL33TW00D mentioned this pull request May 14, 2024
Closed
@FL33TW00D FL33TW00D changed the title feature: Parse enable directives feature: Parse enable directives & SHADER-F16 support May 14, 2024
@FL33TW00D FL33TW00D mentioned this pull request May 14, 2024
Closed
This was referenced May 14, 2024
Open
Open
@FL33TW00D FL33TW00D mentioned this pull request May 15, 2024
Open
@FL33TW00D FL33TW00D marked this pull request as ready for review May 15, 2024 21:19
@FL33TW00D FL33TW00D requested review from a team as code owners May 15, 2024 21:19
@FL33TW00D
Copy link
Contributor Author

I've marked this as ready for review, as the wgpu specific logic is implemented and would be great to start iterating on it.

2 main blockers are:

  1. Merging of the PR on half-rs.
  2. hexf-parse improved implementation.

FL33TW00D
FL33TW00D commented May 15, 2024
View reviewed changes
naga/src/proc/constant_evaluator.rs
//component_wise_float!(self, span, [arg, arg1.unwrap()], |edge, x| {
// Ok([if edge <= x { 1.0 } else { 0.0 }])
//})
todo!()
Copy link
Contributor Author

@FL33TW00D FL33TW00D May 15, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO (any pointers here appreciated)

@FL33TW00D
Copy link
Contributor Author

FL33TW00D commented May 20, 2024 •
edited

Dogfooding works! Fixed a few bugs in 30e12b5. Still waiting on upstream.

@FL33TW00D FL33TW00D mentioned this pull request May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler Awaiting requested review from ErichDonGubler

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FL33TW00D @ErichDonGubler