exec-file: if `--filename` is used, use the provided filename without random suffix #1474

felixfontein · 2024-03-27T20:48:58Z

devstein

LGTM - one comment. I think it's good to merge regardless

cmd/sops/subcommand/exec/exec.go

Signed-off-by: Felix Fontein <felix@fontein.de>

felixfontein force-pushed the exec-filename branch 3 times, most recently from 892c38b to 78f758d Compare March 27, 2024 21:24

felixfontein requested a review from a team March 27, 2024 21:28

felixfontein mentioned this pull request Mar 27, 2024

sops execfile filename should not have a random suffix appended in --no-fifo mode #1473

Closed

felixfontein force-pushed the exec-filename branch from 78f758d to 8c306f6 Compare June 3, 2024 04:37

devstein reviewed Jun 10, 2024

View reviewed changes

cmd/sops/subcommand/exec/exec.go Show resolved Hide resolved

If filename is provided for exec-file, use it without random suffix.

417c20a

Signed-off-by: Felix Fontein <felix@fontein.de>

felixfontein force-pushed the exec-filename branch from 8c306f6 to 417c20a Compare June 11, 2024 04:56

devstein approved these changes Jun 11, 2024

View reviewed changes

devstein merged commit 0da6be8 into getsops:main Jun 11, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

exec-file: if `--filename` is used, use the provided filename without random suffix #1474

exec-file: if `--filename` is used, use the provided filename without random suffix #1474

felixfontein commented Mar 27, 2024

devstein left a comment

exec-file: if --filename is used, use the provided filename without random suffix #1474

exec-file: if --filename is used, use the provided filename without random suffix #1474

Conversation

felixfontein commented Mar 27, 2024

devstein left a comment

Choose a reason for hiding this comment

exec-file: if `--filename` is used, use the provided filename without random suffix #1474

exec-file: if `--filename` is used, use the provided filename without random suffix #1474