Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-idorslug): Updated Subset of Replay Endpoints and API Docs Tests to use organization_id_or_slug #70711

Merged
merged 7 commits into from
May 13, 2024
Merged

feat(api-idorslug): Updated Subset of Replay Endpoints and API Docs Tests to use organization_id_or_slug #70711

merged 7 commits into from
May 13, 2024
+416 −273

Conversation

iamrajjoshi
Copy link
Member

A subset of changes from #70081!

@iamrajjoshi iamrajjoshi self-assigned this May 11, 2024
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@iamrajjoshi
Copy link
Member Author

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

It added the frontend label because of the markdown files.

@iamrajjoshi iamrajjoshi marked this pull request as ready for review May 13, 2024 00:23
@iamrajjoshi iamrajjoshi requested review from a team as code owners May 13, 2024 00:23
@iamrajjoshi iamrajjoshi removed request for a team May 13, 2024 00:24
@codecov Codecov
Copy link

codecov bot commented May 13, 2024

Bundle Report

Bundle size has no change ✅

schew2381
schew2381 reviewed May 13, 2024
View reviewed changes
src/sentry/testutils/cases.py
@@ -1193,7 +1195,10 @@ def setUp(self):

self.init_path = reverse(
"sentry-organization-integrations-setup",
kwargs={"organization_slug": self.organization.slug, "provider_id": self.provider.key},
kwargs={
"organization_slug": self.organization.slug,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing the change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it auto formatted, i haven't updated this endpoint yet.

@iamrajjoshi iamrajjoshi enabled auto-merge (squash) May 13, 2024 16:44
@iamrajjoshi iamrajjoshi merged commit 5d320d2 into master May 13, 2024
46 of 47 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/api-idorslug/rename-path-params/organization_slug_8 branch May 13, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schew2381 schew2381 schew2381 approved these changes

Assignees

@iamrajjoshi iamrajjoshi

Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamrajjoshi @schew2381