feat(crons): Broken crons emails respect "Nudge" notification settings #70708
+55
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
davidenwang
changed the base branch from
master
to
davidenwang/notification-controller-setting
evanpurkhiser
approved these changes
May 13, 2024
Base automatically changed from
davidenwang/notification-controller-setting
to
master
May 14, 2024 22:29
davidenwang
added a commit
that referenced
this pull request
May 14, 2024
Makes the email address retrieval part easier to read, and also makes this PR shorter: #70708
davidenwang
force-pushed
the
davidenwang/notification-controller-nudge
branch
from
6303c12
to
24ef7a8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can disable these emails by enabling/disabling "Nudges" in user settings. Will follow up with docs PR to describe this configurability
Fixes: https://github.com/getsentry/team-crons/issues/180