Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(assignee-selector): Get rid of old component for assignee selector in issue details #70706

Merged
merged 9 commits into from
May 14, 2024

Conversation

MichaelSun48
Copy link
Member

@MichaelSun48 MichaelSun48 commented May 10, 2024

This PR swaps the old assignee selector dropdown in the issue details page for the new one that was recently introduced in the issue stream. The design of the trigger has not been changed with the exception of the chevron, which has been changed to use <Chevron> instead of <IconChevron>.

Closes #69829

Old:
image

New:
image

TODOs:

  • Fix old tests

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Bundle Report

Changes will increase total bundle size by 17.1kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.79MB 17.1kB ⬆️

@MichaelSun48 MichaelSun48 marked this pull request as ready for review May 10, 2024 23:46
@MichaelSun48 MichaelSun48 requested review from a team May 10, 2024 23:46
@malwilley
Copy link
Member

Looks like one of the acceptance tests is failing - you'll probably need to change how the test is selecting the assignee dropdown

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MichaelSun48 MichaelSun48 merged commit 60756d7 into master May 14, 2024
52 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/upgradeIssueDetailsAssigneeSelector branch May 14, 2024 16:45
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Details: Use new assignee selector component
2 participants