feat(performance): Adds trace_status_rate function to span metrics #70685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70685 +/- ##
==========================================
- Coverage 80.04% 80.03% -0.01%
==========================================
Files 6505 6505
Lines 290739 290742 +3
Branches 50102 50102
==========================================
Hits 232709 232709
- Misses 57593 57596 +3
Partials 437 437
|
Comment on lines
+577
to
+588
| "countIf", | ||
| [ | ||
| Column("value"), | ||
| Function( | ||
| "equals", | ||
| [ | ||
| Column("metric_id"), | ||
| self.resolve_metric("span.self_time"), | ||
| ], | ||
| ), | ||
| ], | ||
| ), |
There was a problem hiding this comment.
To make this more robust, should we only count if there is a trace.status? Or can we just assume its always there?
There was a problem hiding this comment.
Hmm, good point. I thought about this for a bit and I think there might scenarios where we want to include spans that don't have a trace.status. For cases where we only want to count spans that have a trace.status, we should be able to just add something like has:trace.status to the discover query to achieve that affect, so I think I'm going to leave this as is for the flexibility.
DominikB2014
approved these changes
May 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds trace_status_rate function to span metrics